Implement pop_equiv() for HashMap #11691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, could you please squash these commits? |
|
This has a similar problem to #11074, and my concerns are in this comment: #11074 (comment) I think that we should make a decision on this before merging. |
|
I've added this to the next meeting agenda |
|
@alexcrichton was this discussed at the last meeting? |
|
Ah sorry, I forgot to comment on this afterwards. We didn't get around to talking about this, and we thought that specific library issues like this shouldn't need to wait for a meeting. I am personally still hesitant to merge due to my comment above. |
|
I agree on not merging it. There should be a better solution for this. I'd strongly suggest to use the |
|
Closing, I've opened #12135 on the equiv + hashmap topic. |
This was referenced Jun 29, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 1, 2023
…entri3 Lint `flatten()` under `lines_filter_map_ok` Fixes rust-lang#11686 changelog: [`lines_filter_map_ok`]: Also lint calls to `flatten()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.